SDK-2254-go-create-qr-code #288

mehmet-yoti · 2023-10-22T22:25:33Z

No description provided.

irotech

Could you please review the commit message with something in line with the goal you want to achieve and split unrelated changes in other commits (example class)?

irotech · 2023-10-31T15:11:59Z

_examples/idv/handlers.session.go

+	if err != nil {
+		return fmt.Errorf("failed to initialise Share client :: %w", err)
+	}
+	//didClient.OverrideAPIURL("https://connect.public.stg1.dmz.yoti.com/share/")


please do not expose internal resources in public repos

digitalidentity/create_qr_code_builder_test.go

irotech · 2023-10-31T15:34:57Z

_examples/idv/handlers.session.go

+	}
+	fmt.Println(string(b))
+
+	shareSession, err := didClient.CreateShareSession(sessionReq)


Better to split this in 2 commits
commit_a: create example for session creation
commit_b: add session QR creation to example (this commit should have the SDK-2254 in the name)

That example is just testing purposes and now we are removing from idv.

irotech · 2023-10-31T15:41:19Z

_examples/idv/idv

out of curiosity, what's this binary file for?

executable in linux @irotech

@mehmet-yoti this and idv.exe should just be added to the .gitignore and delete-committed out of the repo?

digitalidentity/service.go

digitalidentity/service_test.go

klaidas · 2023-10-31T15:52:15Z

digitalidentity/service.go

@@ -80,3 +81,35 @@ func GetShareSession(httpClient requests.HttpClient, sessionID string, clientSdk
 	err = json.Unmarshal(responseBytes, shareSession)
 	return shareSession, err
 }
+
+// CreateQrCode using the supplied sessionID parameter
+func CreateShareQrCode(httpClient requests.HttpClient, sessionID string, clientSdkId, apiUrl string, key *rsa.PrivateKey) (*QrCode, error) {


i think it's missing a request body https://lampkicking.atlassian.net/wiki/spaces/CON/pages/3756458012/Share+v2+Flows#QR-Code-Creation it looks like it accepts some extra fields:

POST /v2/sessions/:sessionId/qr-codes { "transport": "", // optional - default is 'QR_CODE' "displayMode": "" // optional - default is 'INLINE' }

no idea what the accepted values are or if we should give clients a list of possible values, it's not documented there or in the ticket

Java and Node SDK send empty JSON for this endpoint so the server-side defaults are used

umm ok, happy to be consistent with other sdks, just curious why it's even an option if we won't expose these options to the RP

digitalidentity/create_qr_code_builder.go

_examples/idv/handlers.session.go

.gitignore

_examples/idv/handlers.session.go

_examples/digitalidentity/digitalidentity

digital_identity_client.go

klaidas · 2023-11-02T00:35:07Z

just gotta remove a couple things above and should be good

irotech · 2023-11-06T10:50:48Z

Could you please review the commit message with something in line with the goal you want to achieve and split unrelated changes in other commits (example class)?

I hope you're going to rebase and change these commit messages to follow the same format
SDK-1234: This commit addresses this feature and, not to be picky but, a commit message should give you a hint on what changes. A clean GIT log helps in identifying quickly which commit introduced a change that might break (for instance)

SDK-2254: updated tests
SDK-2254 Resolved pr comments
SDK-2254:updated pr changes
SDK-2254 removed unused builder

…escriptions

…dling, simplified some functions

Co-authored-by: Klaidas Urbanavicius <[email protected]>

…nto base func. etc

…etrieve-receipt

Co-authored-by: Klaidas Urbanavicius <[email protected]>

…texts

Co-authored-by: Klaidas Urbanavicius <[email protected]>

Sdk 2235 share v 2 retrieve receipt

SDK-2259:added retrieve qr code

mehmet-yoti added 7 commits October 22, 2023 22:45

SDK-2254: updated tests

9027db5

SDK-2259:added retrieve qr code

6691dec

SDK-2235 added retrieve receipt

be2b96b

SDK-2235 Added Retrieve Receipt

6f50c88

SDK-2235 Added Retrieve Receipt

fb79e33

SDK-2235 Added Retrieve Receipt

1586dea

SDK-2235 Added Retrieve Receipt

c2d3b6c

mehmet-yoti changed the title ~~SDK-2254: updated tests~~ SDK-2254-go-create-qr-code Oct 25, 2023

mehmet-yoti requested review from fofiuiancu and klaidas October 25, 2023 13:01

irotech reviewed Oct 31, 2023

View reviewed changes

klaidas reviewed Oct 31, 2023

View reviewed changes

SDK-2254 Resolved pr comments

46993f4

mehmet-yoti requested review from irotech and klaidas November 1, 2023 09:15

mehmet-yoti added 4 commits November 1, 2023 11:16

SDK-2254 Resolved pr comments

22d0896

SDK-2259:updated needed pr reviews

359a293

SDK-2259:updated needed pr reviews

cb5f083

SDK-2259:updated needed pr reviews

ce57837

klaidas reviewed Nov 2, 2023

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

_examples/idv/handlers.session.go Outdated Show resolved Hide resolved

_examples/digitalidentity/digitalidentity Outdated Show resolved Hide resolved

klaidas reviewed Nov 2, 2023

View reviewed changes

digital_identity_client.go Outdated Show resolved Hide resolved

mehmet-yoti added 2 commits November 2, 2023 09:05

SDK-2254:updated pr changes

5506087

SDK-2254 removed unused builder

384a28b

mehmet-yoti added 4 commits November 7, 2023 08:02

SDK-2254 Resolved pr comments

f61e496

SDK-2254:updated pr changes

708fe86

SDK-2254 removed unused builder

2a0f087

SDK-2259:added retrieve qr code

5912800

mehmet-yoti and others added 29 commits November 7, 2023 23:11

SDK-2259:added retrieve qr code structs

87d61de

SDK-2254 Removed unused examples and updated function namings

6c2d312

SDK-2259:removed unused example files

d40c218

SDK-2254 Removed unused examples and updated function namings

f8657c2

SDK-2259:removed unused example files

4c019b3

SDK-2235:error handling, updated comments

a841a3e

SDK-2235:updated method descriptions and addedd error handlers with d…

87f5098

…escriptions

SDK-2235:added some error handling, updated comments, added error han…

2492915

…dling, simplified some functions

Update digitalidentity/service.go

5bf052f

Co-authored-by: Klaidas Urbanavicius <[email protected]>

Update digitalidentity/service.go

9661755

Co-authored-by: Klaidas Urbanavicius <[email protected]>

Update digitalidentity/service.go

75502ef

Co-authored-by: Klaidas Urbanavicius <[email protected]>

Update digitalidentity/service.go

b7d7b23

Co-authored-by: Klaidas Urbanavicius <[email protected]>

Update digitalidentity/service.go

8e20b5e

Co-authored-by: Klaidas Urbanavicius <[email protected]>

Update digitalidentity/service.go

b893957

Co-authored-by: Klaidas Urbanavicius <[email protected]>

Update digitalidentity/service.go

4993e35

Co-authored-by: Klaidas Urbanavicius <[email protected]>

Update cryptoutil/crypto_utils.go

e52a26c

Co-authored-by: Klaidas Urbanavicius <[email protected]>

Update digitalidentity/service.go

b9d8fed

Co-authored-by: Klaidas Urbanavicius <[email protected]>

Update cryptoutil/crypto_utils.go

c09c2c2

Co-authored-by: Klaidas Urbanavicius <[email protected]>

SDK-2235: added error details, cleaned unneccessary func and merged i…

8dd3c7c

…nto base func. etc

Merge branch 'SDK-2259-go-retrieve-qr-code' into SDK-2235-share-v-2-r…

f705d44

…etrieve-receipt

Update cryptoutil/crypto_utils.go

a4775d2

Co-authored-by: Klaidas Urbanavicius <[email protected]>

SDK-2235:reduced complexity

3da5372

SDK-2235 removed unused method, added panic controls, added error con…

9d403b8

…texts

SDK-2235 added error contexts

af99524

Update digitalidentity/service.go

a3d8314

Co-authored-by: Klaidas Urbanavicius <[email protected]>

Update digitalidentity/service.go

5f1ec57

Co-authored-by: Klaidas Urbanavicius <[email protected]>

SDK-2235 updated error context text

3fb2de7

Merge pull request #289 from getyoti/SDK-2235-share-v-2-retrieve-receipt

ac64677

Sdk 2235 share v 2 retrieve receipt

Merge pull request #290 from getyoti/SDK-2259-go-retrieve-qr-code

fb179ee

SDK-2259:added retrieve qr code

mehmet-yoti merged commit bd35297 into SDK-2230-Expose-share-v2-api Dec 14, 2023
5 of 6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SDK-2254-go-create-qr-code #288

SDK-2254-go-create-qr-code #288

mehmet-yoti commented Oct 22, 2023

irotech left a comment

irotech Oct 31, 2023

irotech Oct 31, 2023

mehmet-yoti Nov 1, 2023

irotech Oct 31, 2023

klaidas Oct 31, 2023

klaidas Oct 31, 2023

irotech Oct 31, 2023

klaidas Nov 2, 2023

klaidas commented Nov 2, 2023

irotech commented Nov 6, 2023

SDK-2254-go-create-qr-code #288

SDK-2254-go-create-qr-code #288

Conversation

mehmet-yoti commented Oct 22, 2023

irotech left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

klaidas commented Nov 2, 2023

irotech commented Nov 6, 2023